ナビゲーションデバッグ画面にTextFieldを配置 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
@packages/features/debug_mode
yumemi-team-review-requester
bot
requested review from
a team,
rizumita and
K9i-0
and removed request for
a team
|
Ready for review 🚀 |
|
Visit the preview URL for this PR (updated for commit 40ee76f): https://flutter-mobile-project-template-catalog--pr293-debug-p-efyjb4s7.web.app (expires Wed, 07 Aug 2024 05:38:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
|
明日レビュー予定です 🙏 |
blendthink
reviewed
Jul 30, 2024
packages/features/debug_mode/lib/src/ui/navigation_debug_page.dart
Outdated
Show resolved
Hide resolved
Comment on lines
103
to
106
| var routePath = routeBase.path; | ||
| if (parentRoute != null) { | ||
| routePath = p.join(parentRoute.path, routePath); | ||
| } |
There was a problem hiding this comment.
処理がシンプルになっていいですね！
ご対応ありがとうございます！
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
（元々はmacrosなどでうまいことGoRouteDataからサンプルパラメータを持って来れないかと試してたのですが、挫折してしまいました...手動入力の形で対応です）
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
確認したこと
動作確認手順
備考