feat(samples): github repository のサンプルアプリパッケージを追加 #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0440da1): https://flutter-mobile-project-template-catalog--pr295-improve-4id0rq6n.web.app (expires Wed, 07 Aug 2024 03:32:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
yumemi-team-review-requester
bot
requested review from
a team,
blendthink and
trm11tkr
and removed request for
a team
|
Ready for review 🚀 |
tatsutakein
force-pushed
the
improve/GH-275-add-github-app-package
branch
from
3f9f5e2 to
72e3f23
Compare
tatsutakein
commented
Jul 30, 2024
Comment on lines
+38
to
+41
| - label: "@samples/github_app" | ||
| files: | ||
| - samples/github_app/.+ | ||
|
|
There was a problem hiding this comment.
melos bs 時に生成されています。
tatsutakein
commented
Jul 30, 2024
Comment on lines
+77
to
+80
| - name: "@samples/github_app" | ||
| color: 73d994 | ||
| description: samples github_app package | ||
|
|
There was a problem hiding this comment.
melos bs 時に生成されています。
tatsutakein
commented
Jul 30, 2024
| @@ -6,6 +6,7 @@ packages: | |||
| - packages/cores/* | |||
| - packages/features/* | |||
| - packages/samples/* | |||
| - samples/* | |||
There was a problem hiding this comment.
新しく sample ディレクトリを認知するよう追加しています。
blendthink
approved these changes
Jul 30, 2024
blendthink
requested changes
Jul 30, 2024
|
@blendthink |
|
丁寧にご確認いただきありがとうございました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
github repository のサンプルアプリパッケージを追加します。
変更ファイル数が多くなってしまうため一旦はパッケージの追加のみとし、実装は別 PR とする予定です。
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
確認したこと
動作確認手順
備考