-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(melos): スクリプトの命名変更 #357
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,18 +50,18 @@ scripts: | |
# スクリプトを Flutter と Dart に分けている | ||
test: | ||
steps: | ||
- test_flutter | ||
- test_dart | ||
- test:flutter | ||
- test:dart | ||
|
||
test_flutter: | ||
test:flutter: | ||
run: flutter test | ||
exec: | ||
concurrency: 1 | ||
packageFilters: | ||
dependsOn: flutter_test | ||
dirExists: test | ||
|
||
test_dart: | ||
test:dart: | ||
run: dart test | ||
exec: | ||
concurrency: 1 | ||
|
@@ -71,53 +71,54 @@ scripts: | |
|
||
# dependsOn で or 条件で指定することができないため | ||
# スクリプトを Flutter と Dart に分けている | ||
report_test: | ||
report:test: | ||
steps: | ||
- report_test_flutter | ||
- report_test_dart | ||
- report:test:flutter | ||
- report:test:dart | ||
|
||
report_test_flutter: | ||
report:test:flutter: | ||
run: flutter test --no-pub --machine > test_report.log | ||
exec: | ||
concurrency: 1 | ||
packageFilters: | ||
dependsOn: flutter_test | ||
dirExists: test | ||
|
||
report_test_dart: | ||
report:test:dart: | ||
run: dart test --file-reporter="json:test_report.log" | ||
exec: | ||
concurrency: 1 | ||
packageFilters: | ||
dependsOn: test | ||
dirExists: test | ||
|
||
# @deprecated `melos format` で代用可能 | ||
# ローカルでフォーマットとdart fix --applyを実行する | ||
format_and_fix: | ||
exec: bash "$MELOS_ROOT_PATH/scripts/format.sh" | ||
Comment on lines
+95
to
98
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. melos のバージョンがあがったことにより、独自で定義しなくても良くなった認識です。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ありがとうございます! そもそもの?疑問になってしまうのですが、#219 にて CI で利用されていたこのスクリプトを There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
LGTM です! |
||
|
||
report_custom_lint:ci: | ||
ci:report:custom_lint: | ||
exec: bash "$MELOS_ROOT_PATH/scripts/report-custom-lint-ci.sh" | ||
packageFilters: | ||
dependsOn: custom_lint | ||
|
||
regenerate_code: melos run regenerate_by_using_gen_l10n && melos run regenerate_by_using_build_runner | ||
gen: melos run gen:l10n && melos run gen:build | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. steps への変更などは #350 にて実施予定です。 |
||
|
||
regenerate_by_using_build_runner: | ||
gen:build: | ||
run: dart run build_runner build -d | ||
exec: | ||
orderDependents: true | ||
packageFilters: | ||
dependsOn: build_runner | ||
|
||
regenerate_by_using_gen_l10n: | ||
gen:l10n: | ||
run: flutter gen-l10n | ||
exec: | ||
orderDependents: true | ||
packageFilters: | ||
dependsOn: flutter_localizations | ||
|
||
yumemi_lints_update: | ||
update:yumemi_lints: | ||
exec: dart run yumemi_lints update | ||
packageFilters: | ||
dependsOn: yumemi_lints | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
関連箇所を併せて変更しています。