Merge pull request #201 from yuque/fix/chrome-extension-bug

fix: 修复 useEffect 中依赖错误导致循环问题
yuque · Nov 7, 2023 · 65bc39d · 65bc39d
2 parents 4b3215f + ae22a38
commit 65bc39d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "yuque-chrome-extension",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "语雀浏览器插件",
   "private": true,
   "releaseNotes": [

diff --git a/src/components/SuperSideBar/impl/ClipAssistant/index.tsx b/src/components/SuperSideBar/impl/ClipAssistant/index.tsx
@@ -232,14 +232,11 @@ function ClipContent() {
   };
 
   useEffect(() => {
-    if (
-      selectSavePosition?.id !== DefaultSavePosition.id ||
-      !!userTags.length
-    ) {
+    if (selectSavePosition?.id !== DefaultSavePosition.id) {
       return;
     }
     handleRequestTag();
-  }, [selectSavePosition, userTags]);
+  }, [selectSavePosition]);
 
   useEffect(() => {
     const onStartSelectArea = () => {