Changing 'classic notebook' label to 'notebook' inorder to include JN7.0 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yuvipanda - We want to test JN 7.0 during a summer course (possibly Data 8) and want the GitHub extension to generate links for launching JN 7.0. Please let me know if this PR is the way forward. |
|
@yuvipanda Does this PR change the label from "classic notebook" to "notebook" in the extension? If yes, can you merge it as few folks had questions whether classic notebook refers to notebook 7. |
|
@balajialg were you able to test this? |
|
@yuvipanda I didn't test it. I just realized that you added instructions to test it manually in the README which I missed reading. I will test manually and circle with back with more info. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at tweaking the label to be inclusive of Jupyter Notebook 7.0 release. @yuvipanda - Please feel free to point me in the right direction if I had made any mistakes with this PR. Thanks in advance!