move to GitHub Actions for CI (tokio-rs#304)

Transitions the project's CI infrastructure, and fixes a bunch of associated tests, clippy warnings, and rustfmt issues.

.github/workflows/continuous-integration-workflow.yaml

@@ -0,0 +1,84 @@
+name: continuous integration
+on: pull_request
+
+jobs:
+
+  rustfmt:
+    runs-on: ubuntu-latest
+    steps:
+      - name: checkout
+        uses: actions/checkout@v2
+      - name: install toolchain
+        uses: actions-rs/toolchain@v1
+        with:
+            toolchain: stable
+            override: true
+            components: rustfmt
+      - name: rustfmt
+        uses: actions-rs/cargo@v1
+        with:
+          command: fmt
+          args: --all -- --check
+
+  clippy:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: install toolchain
+        uses: actions-rs/toolchain@v1
+        with:
+            toolchain: stable
+            override: true
+            components: clippy
+      - name: install ninja
+        uses: seanmiddleditch/gha-setup-ninja@v1
+      - name: cache target directory
+        uses: actions/cache@v1
+        with:
+          path: target
+          key: ${{ runner.os }}-clippy-target-${{ hashFiles('**/Cargo.toml') }}-${{ hashFiles('**/*.rs') }}
+          restore_keys: |
+            ${{ runner.os }}-clippy-target-${{ hashFiles('**/Cargo.toml') }}-
+            ${{ runner.os }}-clippy-target-
+
+      - name: clippy
+        uses: actions-rs/clippy-check@v1
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          args: --workspace --all-targets
+
+  test:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        toolchain:
+          - stable
+          - 1.39.0
+        os:
+          - ubuntu-latest
+          - macos-latest
+          - windows-latest
+    steps:
+      - name: checkout
+        uses: actions/checkout@v2
+      - name: install toolchain
+        uses: actions-rs/toolchain@v1
+        with:
+            toolchain: ${{ matrix.toolchain }}
+            override: true
+            components: rustfmt
+      - name: install ninja
+        uses: seanmiddleditch/gha-setup-ninja@v1
+      - name: cache target directory
+        uses: actions/cache@v1
+        with:
+          path: target
+          key: ${{ runner.os }}-${{ matrix.toolchain }}-target-${{ hashFiles('**/Cargo.toml') }}-${{ hashFiles('**/*.rs') }}
+          restore_keys: |
+            ${{ runner.os }}-${{ matrix.toolchain }}-target-${{ hashFiles('**/Cargo.toml') }}-
+            ${{ runner.os }}-${{ matrix.toolchain }}-target-
+      - name: test
+        uses: actions-rs/cargo@v1
+        with:
+          command: test
+          args: --workspace --all-targets

benches/varint.rs

@@ -48,11 +48,10 @@ fn benchmark_varint(criterion: &mut Criterion, name: &str, mut values: Vec<u64>)
     })
     .throughput(Throughput::Bytes(decoded_len));
 
-    let encoded_len_values = values.clone();
     let encoded_len = Benchmark::new("encoded_len", move |b| {
         b.iter(|| {
             let mut sum = 0;
-            for &value in &encoded_len_values {
+            for &value in &values {
                 sum += encoded_len_varint(value);
             }
             criterion::black_box(sum);

clippy.toml

@@ -0,0 +1 @@
+too-many-arguments-threshold=8

conformance/tests/conformance.rs

@@ -1,3 +1,5 @@
+#![cfg(not(target_os = "windows"))]
+
 use std::env;
 use std::process::Command;
 

prost-build/src/ast.rs

@@ -37,9 +37,9 @@ impl Comments {
             .as_ref()
             .map_or(Vec::new(), get_lines);
         Comments {
-            leading_detached: leading_detached,
-            leading: leading,
-            trailing: trailing,
+            leading_detached,
+            leading,
+            trailing,
         }
     }
 

prost-build/src/code_generator.rs

@@ -105,14 +105,9 @@ impl<'a> CodeGenerator<'a> {
                 code_gen.path.pop();
             }
 
-            let buf = code_gen.buf;
-            code_gen
-                .config
-                .service_generator
-                .as_mut()
-                .map(|service_generator| {
-                    service_generator.finalize(buf);
-                });
+            if let Some(service_generator) = code_gen.config.service_generator.as_mut() {
+                service_generator.finalize(code_gen.buf);
+            }
 
             code_gen.path.pop();
         }
@@ -584,7 +579,7 @@ impl<'a> CodeGenerator<'a> {
 
         self.depth += 1;
         self.path.push(2);
-        for (idx, value) in enum_values.into_iter().enumerate() {
+        for (idx, value) in enum_values.iter().enumerate() {
             // Skip duplicate enum values. Protobuf allows this when the
             // 'allow_alias' option is set.
             if !numbers.insert(value.number()) {
@@ -677,11 +672,9 @@ impl<'a> CodeGenerator<'a> {
             options: service.options.unwrap_or_default(),
         };
 
-        let buf = &mut self.buf;
-        self.config
-            .service_generator
-            .as_mut()
-            .map(move |service_generator| service_generator.generate(service, buf));
+        if let Some(service_generator) = self.config.service_generator.as_mut() {
+            service_generator.generate(service, &mut self.buf)
+        }
     }
 
     fn push_indent(&mut self) {

prost-build/src/ident.rs

@@ -76,6 +76,9 @@ pub fn match_ident(matcher: &str, msg: &str, field: Option<&str>) -> bool {
 
 #[cfg(test)]
 mod tests {
+
+    #![allow(clippy::cognitive_complexity)]
+
     use super::*;
 
     #[test]

prost-build/src/lib.rs

@@ -1,4 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/prost-build/0.6.1")]
+#![allow(clippy::option_as_ref_deref)]
 
 //! `prost-build` compiles `.proto` files into Rust.
 //!
@@ -50,9 +51,10 @@
 //! `build.rs` build-script:
 //!
 //! ```rust,no_run
-//! fn main() {
-//!     prost_build::compile_protos(&["src/items.proto"],
-//!                                 &["src/"]).unwrap();
+//! # use std::io::Result;
+//! fn main() -> Result<()> {
+//!   prost_build::compile_protos(&["src/items.proto"], &["src/"])?;
+//!   Ok(())
 //! }
 //! ```
 //!
@@ -492,11 +494,12 @@ impl Config {
     /// # Example `build.rs`
     ///
     /// ```rust,no_run
-    /// fn main() {
-    ///     let mut prost_build = prost_build::Config::new();
-    ///     prost_build.btree_map(&["."]);
-    ///     prost_build.compile_protos(&["src/frontend.proto", "src/backend.proto"],
-    ///                                &["src"]).unwrap();
+    /// # use std::io::Result;
+    /// fn main() -> Result<()> {
+    ///   let mut prost_build = prost_build::Config::new();
+    ///   prost_build.btree_map(&["."]);
+    ///   prost_build.compile_protos(&["src/frontend.proto", "src/backend.proto"], &["src"])?;
+    ///   Ok(())
     /// }
     /// ```
     pub fn compile_protos<P>(&mut self, protos: &[P], includes: &[P]) -> Result<()>
@@ -658,9 +661,10 @@ impl default::Default for Config {
 /// # Example `build.rs`
 ///
 /// ```rust,no_run
-/// fn main() {
-///     prost_build::compile_protos(&["src/frontend.proto", "src/backend.proto"],
-///                                 &["src"]).unwrap();
+/// # use std::io::Result;
+/// fn main() -> Result<()> {
+///   prost_build::compile_protos(&["src/frontend.proto", "src/backend.proto"], &["src"])?;
+///   Ok(())
 /// }
 /// ```
 ///
@@ -741,7 +745,7 @@ mod tests {
     impl ServiceGenerator for MockServiceGenerator {
         fn generate(&mut self, service: Service, _buf: &mut String) {
             let mut state = self.state.borrow_mut();
-            state.service_names.push(service.name.clone());
+            state.service_names.push(service.name);
         }
 
         fn finalize(&mut self, _buf: &mut String) {

prost-derive/src/field/group.rs

@@ -51,7 +51,7 @@ impl Field {
 
         Ok(Some(Field {
             label: label.unwrap_or(Label::Optional),
-            tag: tag,
+            tag,
         }))
     }