-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animations for player elements #1378
Conversation
|
Fixed both concerns, sorry for missing that. |
You shortened the elapsed time animation, but I still think it unnecessary. Animation doesn't need to be applied everywhere. |
Okay, if that's your only concern, feel free to drop that elapsed time label animation. But now I don't think it's really something that can make people "wait" because it's kind of like it was before when you drag it. Your choice, zhuang. |
If you don't apply the line height limit, the whole UI will move when larger text is displayed, and you'll get a vertical animation for those elements as before. If possible, setting it to the same value as current font size + 3.sp would work best from what I tested. If not, consider changing a font or idk.. Set a fixed font size and prevent it from scalling, as you probably don't care about these when using a bigger font size: |
As for the menu, I'm also thinking about changing the style to list. I found an animation that I prefer more: forward and backward https://m3.material.io/styles/motion/transitions/transition-patterns |
These animations can be done by #1017, so I'll close this pr. Thanks for your contribution! |
Changes:
7e2564c5-608d-4a13-a092-32bacc82e5ca.mp4
@z-huang you might want to lower the slider refresh delay value as I was working on this pull request before your recent changes.