Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Hello, world! #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Java Hello, world! #12

wants to merge 2 commits into from

Conversation

Logank42
Copy link

@Logank42 Logank42 commented Oct 15, 2024

Pull Request Template

Description

Added hello world using java

Checklist

  • My code follows the project's coding style and guidelines.
  • I have tested my implementation to ensure it works as expected.
  • I have included a Makefile if applicable.
  • I have added a README file for the new language implementation.
  • I have updated the .github/workflows/test.yml file to include the new language in the list of languages to test.
  • I have included any dependencies required for the new language implementation in the test workflow.
  • I have reviewed and understood the code before submitting (for AI-generated submissions).

Related Issue

Please link to any related issues here.

Type of Change

  • New language implementation
  • Bug fix
  • Documentation update
  • Other (please describe):

How Has This Been Tested?

I ran the program and Hello, world! was printed

Screenshots (if applicable)

If applicable, add screenshots to help explain your changes.

Additional Information

Add any other information about your pull request here.

Contributing

To contribute to this project, please see the CONTRIBUTING.md file.

License

This project is licensed under the MIT License. For more information, please see the LICENSE file.

public class hello {

public static void main(String[] args) {
System.out.println("Hello, world!");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output should be hello, world (lowercase, no punctuation)

Suggested change
System.out.println("Hello, world!");
System.out.println("hello, world");

## Compilation

```sh
make hello
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be make I think:

Suggested change
make hello
make

## Usage

```sh
./hello
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the usage should be java hello

Suggested change
./hello
java hello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants