i added rust #21
Open
i added rust #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachflower
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Looks good Alex! Just a few tweaks (double check the main README for verification):
- Check the casing on the hello world output in
hello.rs - Change the directory to
rs - Update the
.github/workflows/test.ymlfile and add an entry forrs(installation steps, and execution steps for testing)
rust/hello.rs
Outdated
| @@ -0,0 +1,3 @@ | |||
| fn main() { | |||
| println!("Hello, World!"); | |||
There was a problem hiding this comment.
Looks good! Double check the documentation, the casing and punctuation isn't quite what's been asked for here
| ## Usage | ||
|
|
||
| ```rs | ||
| cargo run |
There was a problem hiding this comment.
I haven't worked with Rust yet, is cargo shipped with it?
There was a problem hiding this comment.
It is a tool that you would have to download
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the changes and the language you are adding or modifying.
Checklist
Makefileif applicable..github/workflows/test.ymlfile to include the new language in the list of languages to test.Related Issue
Please link to any related issues here.
Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Screenshots (if applicable)
If applicable, add screenshots to help explain your changes.
Additional Information
Add any other information about your pull request here.
Contributing
To contribute to this project, please see the CONTRIBUTING.md file.
License
This project is licensed under the MIT License. For more information, please see the LICENSE file.