Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load parsers by kind #415

Closed
wants to merge 6 commits into from
Closed

Load parsers by kind #415

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 27, 2022

This is an idea related to #326, still a draft.

  • loadByKind maps MeasurementKinds to an array of loaders

Then a user wouldn't need to know name of the loaders to use it.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 27, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12863ed
Status: ✅  Deploy successful!
Preview URL: https://f1543971.analysis-ui-components.pages.dev
Branch Preview URL: https://mkind.analysis-ui-components.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Base: 52.32% // Head: 51.89% // Decreases project coverage by -0.42% ⚠️

Coverage data is based on head (12863ed) compared to base (8a6099b).
Patch coverage: 97.32% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   52.32%   51.89%   -0.43%     
==========================================
  Files         126      127       +1     
  Lines        6630     6677      +47     
  Branches      159      145      -14     
==========================================
- Hits         3469     3465       -4     
- Misses       3161     3212      +51     
Impacted Files Coverage Δ
src/app-data/loaders/wdfLoader.ts 30.82% <70.00%> (-53.91%) ⬇️
src/app-data/loaders/biologicLoader.ts 66.46% <100.00%> (+0.41%) ⬆️
src/app-data/loaders/cdfLoader.ts 85.14% <100.00%> (+0.14%) ⬆️
src/app-data/loaders/index.ts 100.00% <100.00%> (ø)
src/app-data/loaders/jcampLoader.ts 75.22% <100.00%> (+0.46%) ⬆️
src/app-data/loaders/loadMeasurements.ts 100.00% <100.00%> (ø)
src/app-data/loaders/loadersByKind.ts 100.00% <100.00%> (ø)
...-data/loaders/proprietary/agilent/cary500Loader.ts 82.22% <100.00%> (-0.20%) ⬇️
src/app-data/loaders/spcLoader.ts 78.57% <100.00%> (+51.29%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos
Copy link
Member

targos commented Nov 28, 2022

Please don't go too far with this. It's something we wanted to discuss before writing any code.

@ghost
Copy link
Author

ghost commented Nov 28, 2022

Please don't go too far with this. It's something we wanted to discuss before writing any code.

No problem, I can drop the PR if this is not the right time or code.

@ghost ghost closed this Jan 19, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants