-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load parsers by kind #415
Load parsers by kind #415
Conversation
Both were used to make the loaders more uniform and explicitly state the interface.
Deploying with
|
Latest commit: |
12863ed
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f1543971.analysis-ui-components.pages.dev |
Branch Preview URL: | https://mkind.analysis-ui-components.pages.dev |
Codecov ReportBase: 52.32% // Head: 51.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
- Coverage 52.32% 51.89% -0.43%
==========================================
Files 126 127 +1
Lines 6630 6677 +47
Branches 159 145 -14
==========================================
- Hits 3469 3465 -4
- Misses 3161 3212 +51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Please don't go too far with this. It's something we wanted to discuss before writing any code. |
No problem, I can drop the PR if this is not the right time or code. |
This is an idea related to #326, still a draft.
loadByKind
mapsMeasurementKind
s to an array of loadersThen a user wouldn't need to know name of the loaders to use it.