Fix tests

Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
zalando-incubator · Mar 25, 2024 · f6ca5d1 · f6ca5d1
1 parent 14694e0
commit f6ca5d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/vertical-pod-autoscaler/pkg/updater/eviction/pods_eviction_restriction_test.go b/vertical-pod-autoscaler/pkg/updater/eviction/pods_eviction_restriction_test.go
@@ -579,7 +579,7 @@ func TestQuickOOMKill(t *testing.T) {
 			WithOomKill("fake", time.Minute).Get()
 	}
 
-	factory, _ := getEvictionRestrictionFactory(nil, nil, &ss, 2, tolerance)
+	factory, _ := getEvictionRestrictionFactory(nil, nil, &ss, nil, 2, tolerance)
 	eviction := factory.NewPodsEvictionRestriction(pods, getBasicVpa())
 
 	// All pods can be evicted because they have an oom kill

diff --git a/vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator_test.go b/vertical-pod-autoscaler/pkg/updater/priority/update_priority_calculator_test.go
@@ -272,7 +272,7 @@ func TestDontUpdatePodWithQuickOOMNoResourceChange(t *testing.T) {
 }
 
 func TestDontUpdatePodWithOOMNoRecommendationChange(t *testing.T) {
-	pod := test.Pod().WithName("POD1").AddContainer(test.BuildTestContainer(containerName, "1", "1")).Get()
+	pod := test.Pod().WithName("POD1").AddContainer(test.Container().WithName(containerName).WithCPURequest(resource.MustParse("1")).WithMemRequest(resource.MustParse("1")).Get()).Get()
 
 	timestampNow := pod.Status.StartTime.Time.Add(time.Hour)
 
@@ -308,8 +308,8 @@ func TestDontUpdatePodWithOOMNoRecommendationChange(t *testing.T) {
 
 func TestUpdatePodWithOOMAnyContainer(t *testing.T) {
 	pod := test.Pod().WithName("POD1").
-		AddContainer(test.BuildTestContainer(containerName, "4", "")).
-		AddContainer(test.BuildTestContainer(secondContainerName, "4", "")).
+		AddContainer(test.Container().WithName(containerName).WithCPURequest(resource.MustParse("4")).Get()).
+		AddContainer(test.Container().WithName(secondContainerName).WithCPURequest(resource.MustParse("4")).Get()).
 		Get()
 
 	// Pretend that the test pod started 11 hours ago.