perf: memoize repeated ops during compile time #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopathi
changed the title
ayruslore
approved these changes
Oct 14, 2024
|
Any edge cases we should check? Like against false caching? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #260. Right now it targets #260. After #260 is merged, I'll target branch main.
Memoize repeated computations of collect fields for the same sub-tree. To memoize, use a separate weakMemo based on WeakMap instead of using a memoize4 or memoize5 functions - this is because not all arguments of the function need to participate in the memo key. Only 2 out of 5 or 6 arguments actually contribute to the memo key.