Bump github.com/zalando/skipper from 0.17.32 to 0.18.38 #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
katyanna
force-pushed
the
dependabot/go_modules/github.com/zalando/skipper-0.18.38
branch
from
b20edb1
to
da9b8b3
Compare
szuecs
reviewed
Oct 19, 2023
| @@ -184,7 +184,7 @@ func (a *Adapter) NewInclusterConfigClientset(ctx context.Context) error { | |||
| IdleConnTimeout: idleConnTimeout, | |||
| Transport: &http.Transport{ | |||
| Proxy: trCfg.Proxy, | |||
| DialContext: trCfg.Dial, | |||
| DialContext: cfg.Dial, | |||
There was a problem hiding this comment.
no, that's basically dropping the work we try to achieve above: having timeouts configured for the client.
There was a problem hiding this comment.
ah no, hmm, maybe you are right, dunno :D
There was a problem hiding this comment.
Can you post some error that you try to fix?
Maybe we can also add a log to see if trCfg.Dial and cfg.Dial are different log with "%p" for example
There was a problem hiding this comment.
oh, then this needs a more detailed check considering the client-go update on TransportConfig.
There was a problem hiding this comment.
kubernetes/client.go:187:33: trCfg.Dial undefined (type *transport.Config has no field or method Dial)
this was the error, because client-go dropped TransportConfig.Dial here
There was a problem hiding this comment.
Ok thanks, then go ahead like this
|
A newer version of github.com/zalando/skipper exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
szuecs
reviewed
Dec 4, 2023
Bumps [github.com/zalando/skipper](https://github.com/zalando/skipper) from 0.17.32 to 0.18.38. - [Release notes](https://github.com/zalando/skipper/releases) - [Commits](zalando/skipper@v0.17.32...v0.18.38) --- updated-dependencies: - dependency-name: github.com/zalando/skipper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
client-go has dropped direct access to Dial from Transport, this commit updates the usage to the upper layer, InClusterConfig. - kubernetes/client-go@5dab9a0 Signed-off-by: Katyanna Moura <[email protected]>
deadcode and varcheck are deprecated. They're currenlty unused throughout the code, so no need for replacement. Signed-off-by: Katyanna Moura <[email protected]>
Fix lint error: Error: kubernetes/pods.go:53:26: Error return value of `informer.AddEventHandler` is not checked (errcheck) Signed-off-by: Katyanna Moura <[email protected]>
Signed-off-by: Sandor Szücs <[email protected]>
szuecs
force-pushed
the
dependabot/go_modules/github.com/zalando/skipper-0.18.38
branch
from
26684df
to
15cfbbb
Compare
Signed-off-by: Sandor Szücs <[email protected]>
|
👍 |
1 similar comment
|
👍 |
szuecs
deleted the
dependabot/go_modules/github.com/zalando/skipper-0.18.38
branch
MustafaSaber
pushed a commit
that referenced
this pull request
Jan 4, 2024
* Bump github.com/zalando/skipper from 0.17.32 to 0.18.38 Bumps [github.com/zalando/skipper](https://github.com/zalando/skipper) from 0.17.32 to 0.18.38. - [Release notes](https://github.com/zalando/skipper/releases) - [Commits](zalando/skipper@v0.17.32...v0.18.38) --- updated-dependencies: - dependency-name: github.com/zalando/skipper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Get Dial directly from InClusterConfig instead of TransportConfig client-go has dropped direct access to Dial from Transport, this commit updates the usage to the upper layer, InClusterConfig. - kubernetes/client-go@5dab9a0 Signed-off-by: Katyanna Moura <[email protected]> * Remove deprecated linters deadcode and varcheck are deprecated. They're currenlty unused throughout the code, so no need for replacement. Signed-off-by: Katyanna Moura <[email protected]> * Check error returned from client-go/SharedInformer.AddEventHandler Fix lint error: Error: kubernetes/pods.go:53:26: Error return value of `informer.AddEventHandler` is not checked (errcheck) Signed-off-by: Katyanna Moura <[email protected]> * fix update and pin k8s dependency to v0.24.17 Signed-off-by: Sandor Szücs <[email protected]> * fix deps Signed-off-by: Sandor Szücs <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Katyanna Moura <[email protected]> Signed-off-by: Sandor Szücs <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Katyanna Moura <[email protected]> Co-authored-by: Sandor Szücs <[email protected]>
katyanna
added a commit
that referenced
this pull request
Jan 18, 2024
* master: Bump github.com/zalando/skipper from 0.17.32 to 0.18.38 (#648) Add test case for rolling in progress stacks Bump github.com/aws/aws-sdk-go from 1.47.0 to 1.49.13 Bump github.com/google/uuid from 1.4.0 to 1.5.0 (#670) Bump github.com/prometheus/client_golang from 1.17.0 to 1.18.0 (#669) Require labels (#666) Bump golang.org/x/crypto from 0.14.0 to 0.17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/zalando/skipper from 0.17.32 to 0.18.38.
Release notes
Sourced from github.com/zalando/skipper's releases.
... (truncated)
Commits
9b57097fix: master build by dropping gosec from GH action, because of recent gosec c...21b58f6fix: GH actions run an outdated Go version, trying to fix as stated in https:...a05ac5ffix otel dependency CVE-2023-45142 (#2686)6f00e95build(deps): bump github.com/instana/go-sensor from 1.56.0 to 1.57.0 (#2677)9df1e2fupdate setup-go action (#2687)c4fa23bbuild(deps): bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (#2678)15cbed6drop: gosec from blockin build in CI pipeline (#2681)30eada3build(deps): bump github.com/andybalholm/brotli from 1.0.5 to 1.0.6 (#2679)2a202c4Do not use endpointregistry in the hotpath (#2673)9de6be2Do not use endpointregistry in the hotpath (#2673)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)