-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] fix flake tests with image validation API errors #7989
Open
demonCoder95
wants to merge
6
commits into
dev
Choose a base branch
from
fix-flake-e2e
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1e0286a
add image-policy-test prefix to allowed softwail namespaces for image…
demonCoder95 cd5042f
update compliant and non-compliant images for apiserver e2e tests
demonCoder95 e63a143
remove image-policy prefix from softfail namespaces
demonCoder95 782dee2
use skipper v0.21.x as compliant images
demonCoder95 aa5113e
use same registry for compliant and non-compliant images
demonCoder95 b86c9c2
use older images for non-compliant images
demonCoder95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These must be real images (i.e. the tag must exist and the image must be considered compliant or non-compliant (see images below) by docker-meta). The reason why there's so many test images is to ensure that the tests using them aren't affected by any caching because that can lead to wrong results.
Meaning we need 8 compliant and 10 non-compliant test images for the test cases or refactor the test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can look into this today, thanks for the review 🙏