Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

fixing wrong Error type #121

Merged
merged 11 commits into from
Oct 11, 2023
Merged

fixing wrong Error type #121

merged 11 commits into from
Oct 11, 2023

Conversation

hibaAkroush
Copy link
Contributor

according to the documentation, onRetry takes an argument of type Error
readme: https://github.com/zalando-incubator/perron#retry-logic

the current Error type is wrong

interface Error {
    name: string;
    message: string;
    stack?: string;
}

the correct type is passed here
https://github.com/zalando-incubator/perron/blob/master/lib/client.ts#L643

@hibaAkroush
Copy link
Contributor Author

👍

@mohitk05
Copy link

👍

2 similar comments
@boopathi
Copy link
Member

👍

@hibaAkroush
Copy link
Contributor Author

👍

@hibaAkroush
Copy link
Contributor Author

👍

@mohitk05
Copy link

👍

@hibaAkroush hibaAkroush reopened this Oct 10, 2023
@hibaAkroush hibaAkroush reopened this Oct 10, 2023
@hibaAkroush
Copy link
Contributor Author

👍

2 similar comments
@hibaAkroush
Copy link
Contributor Author

👍

@hibaAkroush
Copy link
Contributor Author

👍

@jeremycolin
Copy link

👍

1 similar comment
@hibaAkroush
Copy link
Contributor Author

👍

@hibaAkroush hibaAkroush reopened this Oct 11, 2023
@hibaAkroush
Copy link
Contributor Author

👍

@hibaAkroush hibaAkroush reopened this Oct 11, 2023
@hibaAkroush hibaAkroush reopened this Oct 11, 2023
@oporkka
Copy link
Member

oporkka commented Oct 11, 2023

👍

1 similar comment
@boopathi
Copy link
Member

👍

@boopathi boopathi merged commit 5949440 into zalando-incubator:master Oct 11, 2023
14 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mohitk05 mohitk05 mohitk05 approved these changes

@jeremycolin jeremycolin jeremycolin approved these changes

@boopathi boopathi boopathi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hibaAkroush @mohitk05 @boopathi @jeremycolin @oporkka