let isSystemUsername check all system users

[FxKu]

When one defines a fes_user in the manifest and has also streams defined, the database password of this user gets overridden. The secret, however, is not touched. Therefore, removing the user from the manifest immediately fixes the issue.

I found that when initializing robot / manifest users the check for name collisions with already defined system users is only done for the configured SuperUsername and ReplicationUsername - not for e.g. pooler of stream user. I changed it now to a loop over all system users that are already initialized at this point (not in the unit test though). Because, if this check does not happen, somewhere done the line the database role picks up a new random password. fes_user will be part of c.pgUsers and override the existing sytem user with the same name in the list of newUsers to sync here and here. Interestingly, I find no ALTER ROLE statements in the Postgres logs (probably because we don't want to log passwords).

Btw: The same bug affects the connection pooler role as well.

[jopadi]

👍

[FxKu]

👍