Skip to content

Commit

Permalink
add executor service param - fixes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
Semernitskaya committed Oct 2, 2023
1 parent 172c563 commit 8805924
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions riptide-failsafe/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,9 @@ Http.builder().requestFactory(new HttpComponentsClientHttpRequestFactory())
If no executor is specified, the default executor configured by `Failsafe` is used. See [Failsafe DelegatingScheduler class](https://github.com/failsafe-lib/failsafe/blob/master/core/src/main/java/dev/failsafe/internal/util/DelegatingScheduler.java#L111),
and also [Failsafe documentation](https://failsafe.dev/async-execution/#executorservice-configuration) for more information.

**Beware** when specifying a custom `ExecutorService` - the `ExecutorService` should have a core pool size or parallelism
of at least 2 in order for [timeouts](https://github.com/failsafe-lib/failsafe/blob/master/core/src/main/java/dev/failsafe/Timeout.java) to work.
**Beware** when specifying a custom `ExecutorService`:
1. The `ExecutorService` should have a core pool size or parallelism of at least 2 in order for [timeouts](https://github.com/failsafe-lib/failsafe/blob/master/core/src/main/java/dev/failsafe/Timeout.java) to work
2. In general, it is not recommended to specify the same `ExecutorService` for multiple `Http` clients

## Usage

Expand Down

0 comments on commit 8805924

Please sign in to comment.