drop excessive span logs (#1595)

* drop excessive span logs this is removing the `streamBody.byte:` logs which make up the biggest chunk of logs per proxy span. Errors are still logged with the `streamBody.byte:` log. Signed-off-by: Hanno Hecker <[email protected]> * report total number of bytes copied Signed-off-by: Hanno Hecker <[email protected]>
zalando · Nov 6, 2020 · 52a7275 · 52a7275
1 parent 1163682
commit 52a7275
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/proxy/proxy.go b/proxy/proxy.go
@@ -410,11 +410,14 @@ func cloneHeaderExcluding(h http.Header, excludeList map[string]bool) http.Heade
 func copyStream(to flushedResponseWriter, from io.Reader, tracing *proxyTracing, span ot.Span) error {
 	b := make([]byte, proxyBufferSize)
 
+	var bytesCopied int
+	defer func() {
+		tracing.logStreamEvent(span, StreamBodyEvent, fmt.Sprintf("%d", bytesCopied))
+	}()
+
 	for {
 		l, rerr := from.Read(b)
 
-		tracing.logStreamEvent(span, StreamBodyEvent, fmt.Sprintf("%d", l))
-
 		if rerr != nil && rerr != io.EOF {
 			return rerr
 		}
@@ -426,6 +429,7 @@ func copyStream(to flushedResponseWriter, from io.Reader, tracing *proxyTracing,
 			}
 
 			to.Flush()
+			bytesCopied += l
 		}
 
 		if rerr == io.EOF {