proxy: support configurable metrics #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use configed metrics and fallback to global for backwards compatibility. Updates #3026 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added
the
major
| @@ -1309,9 +1309,8 @@ func listenAndServeQuit( | |||
| } | |||
|
|
|||
| if o.EnableConnMetricsServer { | |||
| m := metrics.Default | |||
There was a problem hiding this comment.
minor: why were metrics.Default and mtr were mixed in this function at all?
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 22, 2024
[Changes](zalando/skipper@v0.21.54...v0.21.61) * [build(deps): bump amazonlinux from `ef9435f` to `5478f82` in /fuzz](zalando/skipper#3031) * [build(deps): bump actions/upload-artifact from 4.3.1 to 4.3.2](zalando/skipper#3033) * [build(deps): bump actions/checkout from 4.1.2 to 4.1.3](zalando/skipper#3032) * [build(deps): bump github.com/miekg/dns from 1.1.58 to 1.1.59](zalando/skipper#3030) * [proxy: support configurable metrics](zalando/skipper#3027) * [filters/auth: add login redirect stub support](zalando/skipper#3028) * [filters: move annotate into own package](zalando/skipper#3023) * [filters/auth: add jwtMetrics](zalando/skipper#3020) * [filters/builtin: add annotate filter](zalando/skipper#3022) Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 22, 2024
[Changes](zalando/skipper@v0.21.54...v0.21.61) * `build(deps): bump amazonlinux from `ef9435f` to `5478f82` in /fuzz` zalando/skipper#3031 * `build(deps): bump actions/upload-artifact from 4.3.1 to 4.3.2` zalando/skipper#3033 * `build(deps): bump actions/checkout from 4.1.2 to 4.1.3` zalando/skipper#3032 * `build(deps): bump github.com/miekg/dns from 1.1.58 to 1.1.59` zalando/skipper#3030 * `proxy: support configurable metrics` zalando/skipper#3027 * `filters/auth: add login redirect stub support` zalando/skipper#3028 * `filters: move annotate into own package` zalando/skipper#3023 * `filters/auth: add jwtMetrics` zalando/skipper#3020 * `filters/builtin: add annotate filter` zalando/skipper#3022 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 22, 2024
[Changes](zalando/skipper@v0.21.54...v0.21.61) * zalando/skipper#3031 * zalando/skipper#3033 * zalando/skipper#3032 * zalando/skipper#3030 * zalando/skipper#3027 * zalando/skipper#3028 * zalando/skipper#3023 * zalando/skipper#3020 * zalando/skipper#3022 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Apr 22, 2024
[Changes](zalando/skipper@v0.21.54...v0.21.62) * zalando/skipper#3025 * zalando/skipper#3031 * zalando/skipper#3033 * zalando/skipper#3032 * zalando/skipper#3030 * zalando/skipper#3027 * zalando/skipper#3028 * zalando/skipper#3023 * zalando/skipper#3020 * zalando/skipper#3022 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use configed metrics and fallback to global for backwards compatibility.
Updates #3026