chore(ci): always run should-run step against base commit

Running against last remote commit would induce undesired behavior, especially on pull-request approval. For example a change in integer layer could occur in the pull-request commits list but the changes aren't contained in the last remote commit. Then, on approval, aws_tfhe_integer_tests.yml workflow would be skipped although it should run regarding the base commit.
zama-ai · Feb 10, 2025 · 01aa7d1 · 01aa7d1
1 parent 73412a4
commit 01aa7d1
Show file tree

Hide file tree

Showing 17 changed files with 0 additions and 17 deletions.
diff --git a/.github/workflows/aws_tfhe_fast_tests.yml b/.github/workflows/aws_tfhe_fast_tests.yml
@@ -76,7 +76,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             dependencies:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/aws_tfhe_integer_tests.yml b/.github/workflows/aws_tfhe_integer_tests.yml
@@ -64,7 +64,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             integer:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/aws_tfhe_signed_integer_tests.yml b/.github/workflows/aws_tfhe_signed_integer_tests.yml
@@ -65,7 +65,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             integer:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/aws_tfhe_tests.yml b/.github/workflows/aws_tfhe_tests.yml
@@ -86,7 +86,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             dependencies:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/benchmark_tfhe_zk_pok.yml b/.github/workflows/benchmark_tfhe_zk_pok.yml
@@ -38,7 +38,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             zk_pok:
               - tfhe-zk-pok/**

diff --git a/.github/workflows/benchmark_wasm_client.yml b/.github/workflows/benchmark_wasm_client.yml
@@ -43,7 +43,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             wasm_bench:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/benchmark_zk_pke.yml b/.github/workflows/benchmark_zk_pke.yml
@@ -50,7 +50,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             zk_pok:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/check_ci_files_change.yml b/.github/workflows/check_ci_files_change.yml
@@ -34,7 +34,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             ci:
               - .github/**

diff --git a/.github/workflows/gpu_fast_h100_tests.yml b/.github/workflows/gpu_fast_h100_tests.yml
@@ -54,7 +54,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             gpu:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/gpu_fast_tests.yml b/.github/workflows/gpu_fast_tests.yml
@@ -52,7 +52,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             gpu:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/gpu_full_multi_gpu_tests.yml b/.github/workflows/gpu_full_multi_gpu_tests.yml
@@ -54,7 +54,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             gpu:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/gpu_signed_integer_classic_tests.yml b/.github/workflows/gpu_signed_integer_classic_tests.yml
@@ -54,7 +54,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             gpu:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/gpu_signed_integer_h100_tests.yml b/.github/workflows/gpu_signed_integer_h100_tests.yml
@@ -54,7 +54,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             gpu:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/gpu_signed_integer_tests.yml b/.github/workflows/gpu_signed_integer_tests.yml
@@ -57,7 +57,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             gpu:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/gpu_unsigned_integer_classic_tests.yml b/.github/workflows/gpu_unsigned_integer_classic_tests.yml
@@ -54,7 +54,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             gpu:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/gpu_unsigned_integer_h100_tests.yml b/.github/workflows/gpu_unsigned_integer_h100_tests.yml
@@ -54,7 +54,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             gpu:
               - tfhe/Cargo.toml

diff --git a/.github/workflows/gpu_unsigned_integer_tests.yml b/.github/workflows/gpu_unsigned_integer_tests.yml
@@ -58,7 +58,6 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@d6e91a2266cdb9d62096cebf1e8546899c6aa18f
         with:
-          since_last_remote_commit: true
           files_yaml: |
             gpu:
               - tfhe/Cargo.toml