CudaCompressedList fixes #2036
Open
CudaCompressedList fixes #2036
+94
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Signed and Unsigned DataKind, the degree was incorrectly set, leading to unneeded carry propagations
Some counts where to copied from the correct source to correct destination. And a spurious truncation of a GLWE was done
IceTDrinker
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
I can see how those fell through the cracks, thanks for the added checks and fixes!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @agnesLeroy)
|
seems there are some cuda fails https://github.com/zama-ai/tfhe-rs/actions/runs/13202943746/job/36859384892#step:6:629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs:
One in the metadata after GPU decompression, leading to more carry propagation done
Another in the conversion between Cpu and Gpu CompressedList
This change is