chore(all): [v16] Bump eslint and related packages, bump prettier and run on codebase #927

rnegron · 2024-12-03T13:52:23Z

Note: This MR is based on top of #926. It should be re-based and merged into the v16 branch after that one is merged.

Packages Updates

eslint 8.32.0 -> 9.16.0
eslint-config-prettier 8.6.0 -> 9.16.0
eslint-plugin-import: 2.27.5 -> 2.31.0
eslint-plugin-mocha: 9.0.0 -> 10.5.0
eslint-plugin-n: 15.6.1 -> 17.14.0
eslint-plugin-promise: 6.1.1 -> 7.2.1
prettier: 2.8.3 -> 3.4.1

Package Removals

eslint-plugin-standard: see Eliminate eslint-plugin-standard standard/standard#1316

Other Changes

Pin engine to >=18.18 for the cli package, to mirror the upgraded eslint dependency...
The vast majority of the file changes in this PR are due to the trailingCommas option in prettier, which had its default value changed from "es5" to "all" in v3.0.0
- Even when using "es5", running prettier on the codebase generates a lot of file changes. So I figured we should just keep the default value then.
.eslintrc is replaced by eslint.config.cjs (auto-generated via npx @eslint/migrate-config .eslintrc --commonjs according to the migration guide, which then required we install globals, @eslint/js and @eslint/eslintrc)
.eslintignore: "ESLintIgnoreWarning: The ".eslintignore" file is no longer supported. Switch to using the "ignores" property in "eslint.config.js": https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files"

This reverts commit 840d0ae.

This reverts commit df8a16f.

rnegron · 2024-12-03T13:59:32Z

scripts/bump.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-
+/* eslint-disable array-callback-return */


Calling out this specific disable I had to add to avoid changing some .map() calls below

rnegron · 2024-12-03T14:13:22Z

packages/cli/src/utils/convert.js

@@ -40,8 +40,9 @@ const createFile = async (content, filename, dir) => {
  endSpinner();
 };

-const prettifyJs = (code) =>
+const prettifyJs = async (code) =>


prettier.format returns a Promise since v3. This means renderDefinitionSlice below which uses prettifyJs needs to await it. Interestingly, the callers for renderDefinitionSlice itself already awaited the response 👍🏻

The other usage of prettifyJs is in renderIndex which already returns a Promise.

rnegron · 2024-12-03T14:14:14Z

package.json

@@ -46,7 +48,7 @@
      "eslint --fix --quiet"
    ],
    "*.{js,json}": [
-      "prettier --write"
+      "prettier --write --ignore-path=.prettierignore"


Not sure if this has much effect; keeping previous behavior to avoid surprises just in case.

rnegron · 2024-12-03T14:21:51Z

packages/core/test/moduleuserapp/export-func.js

@@ -1,3 +1,3 @@
 module.exports = (z, bundle) => {
-  return [{ id: 1234 }] || bundle;


Calling out this change I did to fix no-constant-binary-expression eslint error

…-bundlers-and-formatters

rnegron · 2024-12-04T12:57:47Z

eslint.config.cjs

+});
+
+module.exports = [{
+    ignores: [


Moved .eslintignore into this ignores property as required by eslint 9

rnegron · 2024-12-04T12:59:13Z

eslint.config.cjs

+        "packages/cli/scaffold/*.js",
+        "packages/cli/src/generators/templates/**/*.template.js",
+        "**/.yarn",
+        "example-apps/onedrive/test/*",


Note: I added this new ignore rule for onedrive example app tests; there seems to be some issue with eslint trying to read the .eslintrc.json in that root directory (?!) which I didn't want to get into...

Yikes, yeah that seems reasonable!

rnegron · 2024-12-04T13:02:53Z

packages/cli/package.json

@@ -19,7 +19,7 @@
    "/oclif.manifest.json"
  ],
  "engines": {
-    "node": ">=18"
+    "node": ">=18.18"


Note this stricter requirement; eslint 9 requires the 18.18 minor version, so I figure it makes sense to enforce this for at least zapier-platform-cli

kreddlear

Whew, that's a lot of commas 😅 Thanks for adding comments on the main changes for this, that made it much easier to review! Looks great 👍

kreddlear · 2024-12-04T16:35:31Z

eslint.config.cjs

+        "packages/cli/scaffold/*.js",
+        "packages/cli/src/generators/templates/**/*.template.js",
+        "**/.yarn",
+        "example-apps/onedrive/test/*",


Yikes, yeah that seems reasonable!

* Param name fixed. * Width of produced markdown docs fixed to 80 chars. * Deps of @oclif packages upgraded. * Command args and flags upgraded. * Run scripts updated. * Tests for ZapierBaseCommand upgraded with command flag tests added. * Tests for register command upgraded. * logList is really printing tables (without borders). * argv parsed. * yarn lock file updated. * Docs updated. * Function name consolidated. * @oclif/core requires node >= 18. * Old code removed. * build(schema-to-ts): [PDE-5183] schema-to-ts is now part of yarn workspace (#913) * BREAKING CHANGE(all): [v16] Bump dependency package versions (#926) * bumping oclif packages * bump more packages * upgrade Yeoman enviornment to latest v3 * dotenv added a package.json * more package upgrades * use promises instead of callback * revert jsonschema upgrade as it breaks a test * bump * upgrade Lerna to v8 * upgrade prettier to latest v3 * run prettier with trailingComma: es5 * upgrade husky * husky followups * Revert "upgrade prettier to latest v3" This reverts commit 840d0ae. * Revert "run prettier with trailingComma: es5" This reverts commit df8a16f. * bump mocha, dotenv and oclif core patch * undo convert changes * chore(all): [v16] Bump eslint and related packages, bump prettier and run on codebase (#927) * bumping oclif packages * bump more packages * upgrade Yeoman enviornment to latest v3 * dotenv added a package.json * more package upgrades * use promises instead of callback * revert jsonschema upgrade as it breaks a test * bump * upgrade Lerna to v8 * upgrade prettier to latest v3 * run prettier with trailingComma: es5 * upgrade husky * husky followups * Revert "upgrade prettier to latest v3" This reverts commit 840d0ae. * Revert "run prettier with trailingComma: es5" This reverts commit df8a16f. * bump mocha, dotenv and oclif core patch * undo convert changes * bump eslint and related packages * prettier bump, run prettier * fix eslintignore * fix test * run over example-apps as well * rebuild yarn.lock * chore(types): Add type for z.request option skipEncodingChars (#928) --------- Co-authored-by: szchenghuang <[email protected]> Co-authored-by: Thomas Cranny <[email protected]>

* chore(all) [PDE-4089]: v16 release development branch (#923) * Param name fixed. * Width of produced markdown docs fixed to 80 chars. * Deps of @oclif packages upgraded. * Command args and flags upgraded. * Run scripts updated. * Tests for ZapierBaseCommand upgraded with command flag tests added. * Tests for register command upgraded. * logList is really printing tables (without borders). * argv parsed. * yarn lock file updated. * Docs updated. * Function name consolidated. * @oclif/core requires node >= 18. * Old code removed. * build(schema-to-ts): [PDE-5183] schema-to-ts is now part of yarn workspace (#913) * BREAKING CHANGE(all): [v16] Bump dependency package versions (#926) * bumping oclif packages * bump more packages * upgrade Yeoman enviornment to latest v3 * dotenv added a package.json * more package upgrades * use promises instead of callback * revert jsonschema upgrade as it breaks a test * bump * upgrade Lerna to v8 * upgrade prettier to latest v3 * run prettier with trailingComma: es5 * upgrade husky * husky followups * Revert "upgrade prettier to latest v3" This reverts commit 840d0ae. * Revert "run prettier with trailingComma: es5" This reverts commit df8a16f. * bump mocha, dotenv and oclif core patch * undo convert changes * chore(all): [v16] Bump eslint and related packages, bump prettier and run on codebase (#927) * bumping oclif packages * bump more packages * upgrade Yeoman enviornment to latest v3 * dotenv added a package.json * more package upgrades * use promises instead of callback * revert jsonschema upgrade as it breaks a test * bump * upgrade Lerna to v8 * upgrade prettier to latest v3 * run prettier with trailingComma: es5 * upgrade husky * husky followups * Revert "upgrade prettier to latest v3" This reverts commit 840d0ae. * Revert "run prettier with trailingComma: es5" This reverts commit df8a16f. * bump mocha, dotenv and oclif core patch * undo convert changes * bump eslint and related packages * prettier bump, run prettier * fix eslintignore * fix test * run over example-apps as well * rebuild yarn.lock * chore(types): Add type for z.request option skipEncodingChars (#928) --------- Co-authored-by: szchenghuang <[email protected]> Co-authored-by: Thomas Cranny <[email protected]> * add changelog * Bump cli, core, schema 15.19.0 -> 16.0.0 --------- Co-authored-by: szchenghuang <[email protected]> Co-authored-by: Thomas Cranny <[email protected]>

rnegron added 16 commits November 25, 2024 15:08

bumping oclif packages

6ba9bcf

bump more packages

031c21f

upgrade Yeoman enviornment to latest v3

13dc50d

dotenv added a package.json

34b54a9

more package upgrades

f95dd7b

use promises instead of callback

a128bcb

revert jsonschema upgrade as it breaks a test

69f205a

bump

adf14e2

upgrade Lerna to v8

24d5c39

upgrade prettier to latest v3

840d0ae

run prettier with trailingComma: es5

df8a16f

upgrade husky

9a0b9ef

husky followups

8c4384d

Revert "upgrade prettier to latest v3"

3926632

This reverts commit 840d0ae.

Revert "run prettier with trailingComma: es5"

9f04ff6

This reverts commit df8a16f.

bump mocha, dotenv and oclif core patch

549acae

rnegron commented Dec 3, 2024

View reviewed changes

rnegron mentioned this pull request Dec 3, 2024

BREAKING CHANGE(all): [v16] Bump dependency package versions #926

Merged

rnegron commented Dec 3, 2024

View reviewed changes

rnegron added 4 commits December 3, 2024 10:23

undo convert changes

6612ca0

bump eslint and related packages

4aca06f

prettier bump, run prettier

56e2791

fix eslintignore

f9a0e95

rnegron force-pushed the PDE-4097-bundlers-and-formatters branch from 879a606 to f9a0e95 Compare December 3, 2024 14:39

fix test

707a40b

rnegron marked this pull request as ready for review December 3, 2024 15:08

rnegron requested a review from a team as a code owner December 3, 2024 15:08

run over example-apps as well

6812b4e

rnegron force-pushed the PDE-4097-bundlers-and-formatters branch from 0d5a9e5 to 6812b4e Compare December 3, 2024 15:15

Base automatically changed from PDE-4097 to zapier-platform-major-release-16.0.0-dev December 4, 2024 12:39

rnegron added 2 commits December 4, 2024 08:41

Merge branch 'zapier-platform-major-release-16.0.0-dev' into PDE-4097…

9a14d13

…-bundlers-and-formatters

rebuild yarn.lock

bd14c99

rnegron commented Dec 4, 2024

View reviewed changes

kreddlear approved these changes Dec 4, 2024

View reviewed changes

rnegron merged commit 349f4b3 into zapier-platform-major-release-16.0.0-dev Dec 4, 2024
14 checks passed

rnegron deleted the PDE-4097-bundlers-and-formatters branch December 4, 2024 17:58

rnegron mentioned this pull request Dec 4, 2024

chore(all) [PDE-4089]: v16 release development branch #923

Merged

rnegron mentioned this pull request Dec 11, 2024

[PDE-4089] chore(cli, core, schema): Release v16.0.0 #929

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(all): [v16] Bump eslint and related packages, bump prettier and run on codebase #927

chore(all): [v16] Bump eslint and related packages, bump prettier and run on codebase #927

rnegron commented Dec 3, 2024 •

edited

Loading

rnegron Dec 3, 2024

rnegron Dec 3, 2024

rnegron Dec 3, 2024

rnegron Dec 3, 2024

rnegron Dec 4, 2024

rnegron Dec 4, 2024

kreddlear Dec 4, 2024

rnegron Dec 4, 2024

kreddlear left a comment

kreddlear Dec 4, 2024

		@@ -1,5 +1,5 @@
		#!/usr/bin/env node

		/* eslint-disable array-callback-return */

		@@ -1,3 +1,3 @@
		module.exports = (z, bundle) => {
		return [{ id: 1234 }] \|\| bundle;

chore(all): [v16] Bump eslint and related packages, bump prettier and run on codebase #927

chore(all): [v16] Bump eslint and related packages, bump prettier and run on codebase #927

Conversation

rnegron commented Dec 3, 2024 • edited Loading

Packages Updates

Package Removals

Other Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kreddlear left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rnegron commented Dec 3, 2024 •

edited

Loading