Skip to content

Commit

Permalink
todo
Browse files Browse the repository at this point in the history
Signed-off-by: Austin Abro <[email protected]>
  • Loading branch information
AustinAbro321 committed Oct 30, 2024
1 parent 51e74e5 commit 19e07f0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/pkg/packager/actions/actions.go
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ func actionRun(ctx context.Context, cfg v1alpha1.ZarfComponentActionDefaults, cm
if !cfg.Mute {
execCfg.Stdout = spinner
execCfg.Stderr = spinner

if logger.Enabled(ctx) {
execCfg.Print = true
}
Expand Down
2 changes: 2 additions & 0 deletions src/pkg/utils/exec/exec.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ func CmdWithContext(ctx context.Context, config Config, command string, args ...
&stderrBuf,
}

// TODO (@austinabro321) remove config options for stdout/stderr once logger is released
// as these options seem to have been added specifically for the spinner
// Add the writers if requested.
if config.Stdout != nil {
stdoutWriters = append(stdoutWriters, config.Stdout)
Expand Down

0 comments on commit 19e07f0

Please sign in to comment.