Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve the Info and Debug logging for image pulls #3149

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Oct 25, 2024

Description

@AustinAbro321 suggested this improvement to the image pull logging while we reviewed #3132. This gives users better feedback into the parts of pull that we expect will take a while. Also added durations to the debug "done" logs so we get a bit more perf data.

Related Issue

Relates to #3132

Checklist before merging

@mkcp mkcp self-assigned this Oct 25, 2024
@mkcp mkcp requested review from a team as code owners October 25, 2024 21:32
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 5424d7d
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/671fca5b9e23850008d90f99

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/images/pull.go 43.75% 17 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/internal/packager/images/pull.go 44.27% <43.75%> (+0.15%) ⬆️

@mkcp mkcp added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 1605d80 Oct 28, 2024
26 checks passed
@mkcp mkcp deleted the mkcp/img-pull-slog branch October 28, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants