Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logger package deploy #3159

Merged
merged 22 commits into from
Oct 31, 2024
Merged

chore: add logger package deploy #3159

merged 22 commits into from
Oct 31, 2024

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Oct 29, 2024

Description

add slogger for package deploy. Example below. Note that we will not print connect strings or the credentials table after deploy for --log-format="console" after this is merged. Once we've refactored to packager2 it becomes easier to do that in the future. For now, since we have the commands zarf connect list and zarf tools get-creds which achieve the same affect, I feel comfortable with this change.
image

Related Issue

Relates to #2576

Checklist before merging

Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit ad895a6
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67238a2ea7c9270008d20a1a

Copy link

codecov bot commented Oct 29, 2024

Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review October 30, 2024 13:08
@AustinAbro321 AustinAbro321 requested review from a team as code owners October 30, 2024 13:08
Signed-off-by: Austin Abro <[email protected]>
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits around log capitalization, some non-blocking comments about adding metadata to some log lines, and a potential bug/dead code about a Handler() value that doesn't seem to be used. Overall, good work!

src/internal/git/repository.go Outdated Show resolved Hide resolved
src/internal/git/repository.go Outdated Show resolved Hide resolved
src/internal/git/repository.go Outdated Show resolved Hide resolved
src/internal/packager/helm/chart.go Outdated Show resolved Hide resolved
src/internal/packager/helm/utils.go Show resolved Hide resolved
src/pkg/packager/deploy.go Show resolved Hide resolved
src/pkg/packager/deploy.go Outdated Show resolved Hide resolved
src/pkg/packager/deploy.go Show resolved Hide resolved
src/pkg/packager/sources/tarball.go Outdated Show resolved Hide resolved
src/pkg/zoci/common.go Show resolved Hide resolved
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 1180947 Oct 31, 2024
46 checks passed
@AustinAbro321 AustinAbro321 deleted the slog-package-deploy branch October 31, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants