Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use console-slogger as text handler #3167

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Oct 31, 2024

Description

The team has discussed the default logging experience in depth and arrived at using console-slog as the intended default "text" handler. No color for now though, but maybe in the future. (delete "console" if we add color to text)

Related Issue

Relates to #2576

Checklist before merging

@mkcp mkcp self-assigned this Oct 31, 2024
@mkcp mkcp requested review from a team as code owners October 31, 2024 15:55
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 19c0972
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6723a875388e110008c7d39f

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/pkg/logger/logger.go 70.32% <100.00%> (+1.01%) ⬆️

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 1e906ff Oct 31, 2024
26 checks passed
@AustinAbro321 AustinAbro321 deleted the mkcp/text-format branch October 31, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants