Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make the nightly tests run only in zarf-dev/zarf #3174

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

joonas
Copy link
Contributor

@joonas joonas commented Nov 3, 2024

Description

Since individual forks are unlikely to have all of the secrets necessary for running these two jobs, it would probably make sense to only limit them to be run in the zarf-dev/zarf repository.

Related Issue

Fixes #

Relates to #

Checklist before merging

@joonas joonas requested review from a team as code owners November 3, 2024 16:13
Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit f20024d
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6727a1497e38b7000811151b

Copy link
Member

@phillebaba phillebaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@phillebaba phillebaba added this pull request to the merge queue Nov 4, 2024
Merged via the queue into zarf-dev:main with commit a2c3ad3 Nov 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants