Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly delete invalid layers during image pull #3358

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Dec 20, 2024

Description

Zarf was not properly deleting invalid layers during image pull

Related Issue

Relates to #3194 - pretty sure this will fix it, but I will give it some time to see if the flake disappears

Checklist before merging

Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321 AustinAbro321 requested review from a team as code owners December 20, 2024 17:54
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 42608b5
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6765cc11aca6400008ff39ad

if err != nil {
return err
}
cacheDir := filepath.Join(absPath, layout.ImagesDir)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue was that we were expecting the contents to be under an "images" folder which does not exist in the crane cache

Signed-off-by: Austin Abro <[email protected]>
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/images/pull.go 56.25% 4 Missing and 3 partials ⚠️
Files with missing lines Coverage Δ
src/internal/packager/images/pull.go 55.35% <56.25%> (+6.40%) ⬆️

... and 4 files with indirect coverage changes

Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant