zipstore delitems via override

zarr/storage.py

@@ -1779,7 +1779,25 @@ def __setitem__(self, key, value):
             self.zf.writestr(keyinfo, value)
 
     def __delitem__(self, key):
-        raise NotImplementedError
+
+        value = b""
+
+        with self.mutex:
+            try:
+                self.zf.getinfo(key)
+            except KeyError:
+                raise KeyError("Cannot delete a non-existent key")
+            keyinfo = zipfile.ZipInfo(filename=key, 
+                                        date_time=time.localtime(time.time())[:6])
+            keyinfo.compress_type = self.compression
+            if keyinfo.filename[-1] == os.sep:
+                keyinfo.external_attr = 0o40775 << 16   # drwxrwxr-x
+                keyinfo.external_attr |= 0x10           # MS-DOS directory flag
+            else:
+                keyinfo.external_attr = 0o644 << 16     # ?rw-r--r--
+
+            self.zf.writestr(keyinfo, value)
+
 
     def __eq__(self, other):
         return (
@@ -1807,6 +1825,7 @@ def __contains__(self, key):
         try:
             with self.mutex:
                 self.zf.getinfo(key)
+
         except KeyError:
             return False
         else:

zarr/tests/test_storage.py

@@ -192,6 +192,14 @@ def test_pop(self):
 
         store.close()
 
+    def test_delitem(self):
+        store = self.create_store()
+        store[self.root + 'foo'] = b'bar'
+
+        del store[self.root + 'foo']
+
+        assert store[self.root + 'foo'] == b''
+
     def test_popitem(self):
         store = self.create_store()
         store[self.root + 'foo'] = b'bar'
@@ -1792,22 +1800,24 @@ def test_flush(self):
         store.flush()
         assert store[self.root + 'foo'] == b'bar'
         store.close()
-
+        
         store = self.ZipStoreClass('data/store.zip', mode='r')
         store.flush()  # no-op
 
     def test_context_manager(self):
         with self.create_store() as store:
             store[self.root + 'foo'] = b'bar'
             store[self.root + 'baz'] = b'qux'
-            assert 2 == len(store)
+            assert 2 == len(store)       
 
     def test_pop(self):
         # override because not implemented
         store = self.create_store()
         store[self.root + 'foo'] = b'bar'
-        with pytest.raises(NotImplementedError):
-            store.pop(self.root + 'foo')
+
+        store.pop(self.root + 'foo')
+
+        assert store[self.root + 'foo'] == b""
 
     def test_popitem(self):
         # override because not implemented