Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zarr.group now accept the meta_array argument #1489

Merged
merged 2 commits into from
Aug 11, 2023
Merged

zarr.group now accept the meta_array argument #1489

merged 2 commits into from
Aug 11, 2023

Conversation

madsbk
Copy link
Contributor

@madsbk madsbk commented Aug 7, 2023 •
edited
Loading

Now zarr.group forwards the meta_array argument to zarr.Group. Fixes #1484.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #1489 (dd4a64d) into main (6ed4d78) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1489   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines        14732     14733    +1     
=========================================
+ Hits         14732     14733    +1
Files Changed Coverage Δ
zarr/hierarchy.py 100.00% <ø> (ø)
zarr/tests/test_meta_array.py 100.00% <100.00%> (ø)

@madsbk madsbk marked this pull request as ready for review August 7, 2023 12:16
joshmoore
joshmoore approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @madsbk!

@joshmoore joshmoore merged commit 12af7f1 into zarr-developers:main Aug 11, 2023
19 checks passed
@madsbk madsbk deleted the group_accept_meta_array branch August 14, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore joshmoore approved these changes

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zarr.group(meta_array=...) argument?
2 participants
@madsbk @joshmoore