Enable ruff/pyupgrade rules (UP) and fix issues #1703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
UP
branch
2 times, most recently
from
da3e3da
to
8ad56ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
=========================================
+ Coverage 0 99.98% +99.98%
=========================================
Files 0 38 +38
Lines 0 14674 +14674
=========================================
+ Hits 0 14672 +14672
- Misses 0 2 +2
|
Saransh-cpp
reviewed
Mar 12, 2024
As suggested by Repo-Review.
DimitriPapadopoulos
force-pushed
the
UP
branch
3 times, most recently
from
bb9bfe9
to
85dea5e
Compare
6 tasks
UP006 Use `dict` instead of `Dict` for type annotation UP006 Use `list` instead of `List` for type annotation UP006 Use `tuple` instead of `Tuple` for type annotation https://docs.astral.sh/ruff/rules/non-pep585-annotation/
UP031 Use format specifiers instead of percent format https://docs.astral.sh/ruff/rules/printf-string-formatting/
UP033 Use `@functools.cache` instead of `@functools.lru_cache(maxsize=None)` https://docs.astral.sh/ruff/rules/lru-cache-with-maxsize-none/
UP035 Import from `collections.abc` instead: `Iterable`, `Iterator`, `Mapping`, `Sequence` https://docs.astral.sh/ruff/rules/deprecated-import/
|
@DimitriPapadopoulos - thanks for moving your focus over to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep applying repo-review suggestions (#1701).
TODO: