Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncGenerator should not yield None #2464

Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

The None was added in 0e035fb / #1844, let's try to remove it.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

The `None` was added in 0e035fb, let's try to remove it.
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitriPapadopoulos
Copy link
Contributor Author

Very informative. I'll read it more closely, but so far I understand there are two options:

  • the recommended option, no async in the abstract method,
  • the alternative, async and phony yield in the abstract method.

In any case, the above applies to #2381. I have decided to remove None in this separate PR, as things were getting pretty complex.

@jhamman jhamman merged commit f05413e into zarr-developers:main Nov 5, 2024
46 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the AsyncGenerator_None branch November 5, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants