Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing mandatory keyword argument #2465

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Missing mandatory keyword argument #2465

merged 1 commit into from
Nov 5, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Nov 5, 2024 •
edited
Loading

The keyword argument shape is mandatory.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review November 5, 2024 07:59
@DimitriPapadopoulos
Missing mandatory keyword argument
05d7207 
The keyword argument `shape` is mandatory.
@jhamman jhamman merged commit 680142f into zarr-developers:main Nov 5, 2024
24 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the mandatory_shape branch November 5, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @jhamman