code review

zauberzeug · Oct 25, 2024 · be2aaa2 · be2aaa2
1 parent 3862bef
commit be2aaa2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/nicegui/elements/image.py b/nicegui/elements/image.py
@@ -5,6 +5,7 @@
 from typing import Union
 
 from .. import optional_features
+from ..logging import log
 from .mixins.source_element import SourceElement
 
 try:
@@ -37,6 +38,9 @@ def _set_props(self, source: Union[str, Path, 'PIL_Image']) -> None:
 
     def force_reload(self) -> None:
         """Force the image to reload from the source."""
+        if self._props['src'].startswith('data:'):
+            log.warning('ui.image: force_reload() only works with network sources (not base64)')
+            return
         self._props['t'] = time.time()
         self.update()
 

diff --git a/nicegui/elements/interactive_image.py b/nicegui/elements/interactive_image.py
@@ -96,8 +96,8 @@ def _set_props(self, source: Union[str, Path, 'PIL_Image']) -> None:  # noqa: UP
 
     def force_reload(self) -> None:
         """Force the image to reload from the source."""
-        if self.source.startswith('data:'):
-            log.warning('interactive_image: force_reload() only works with network sources (not base64)')
+        if self._props['src'].startswith('data:'):
+            log.warning('ui.interactive_image: force_reload() only works with network sources (not base64)')
             return
         self._props['t'] = time.time()
         self.update()