Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with snakefmt, issue with mamba version in CI #111

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

fgypas
Copy link
Member

@fgypas fgypas commented Mar 10, 2023

Description

Fix issue with snakefmt (remove consecutive comment lines) and remove exact mamba version from CI.

Fixes #109 #110

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation updated

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have updated the project's documentation

@fgypas fgypas requested review from mkatsanto and uniqueg March 10, 2023 08:31
@fgypas
Copy link
Member Author

fgypas commented Mar 10, 2023

There are some new comments in the issues. Please let me know if we need to make further adjustments.

Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like snakefmt 0.8.0 is run against the workflow in the CI and it is not complaining. So the code changes seem to be effective.

Issues with Python 3.7.4 vs 3.10 (#108) can be addressed in another PR.

@mkatsanto mkatsanto changed the title Fix issue with snakefmt. Fix issue with mamba version in CI. fix: issue with snakefmt. issue with mamba version in CI. Mar 10, 2023
@mkatsanto mkatsanto changed the title fix: issue with snakefmt. issue with mamba version in CI. fix: issue with snakefmt, issue with mamba version in CI Mar 10, 2023
@mkatsanto mkatsanto merged commit 2f08e8c into dev Mar 10, 2023
@mkatsanto mkatsanto deleted the fix-issue-with-snakefmt branch March 10, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: issue with snakefmt in snakemake workflow catalog
3 participants