Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update opentelemetry #1377

Merged
merged 12 commits into from
Mar 2, 2023
Merged

build(deps): update opentelemetry #1377

merged 12 commits into from
Mar 2, 2023

Conversation

tpluscode
Copy link
Collaborator

No description provided.

@tpluscode tpluscode requested a review from ludovicm67 February 14, 2023 15:01
@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2023

🦋 Changeset detected

Latest commit: 38a0114

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-creator/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #1377 (38a0114) into master (5a7262e) will decrease coverage by 0.08%.
The diff coverage is 51.28%.

@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
- Coverage   80.84%   80.77%   -0.08%     
==========================================
  Files         197      196       -1     
  Lines       13383    13399      +16     
  Branches      736      736              
==========================================
+ Hits        10820    10823       +3     
- Misses       2555     2568      +13     
  Partials        8        8              
Impacted Files Coverage Δ
cli/lib/otel/index.ts 0.00% <0.00%> (ø)
cli/server.ts 0.00% <0.00%> (ø)
cli/lib/bufferDebug.ts 97.64% <100.00%> (-0.14%) ⬇️
cli/lib/counters.ts 100.00% <100.00%> (ø)
apis/core/lib/domain/queries/dimension-mappings.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cli/lib/otel/index.ts Outdated Show resolved Hide resolved
cli/lib/otel/index.ts Outdated Show resolved Hide resolved
cli/lib/otel/index.ts Outdated Show resolved Hide resolved
@tpluscode
Copy link
Collaborator Author

Jaeger traces are back when I applied your changes but no metrics are being collected still

I'm pretty sure that I am configuring something wrong. Compared to the example you showed me @ludovicm67, I am using NodeSDK class. However when I added the metric reader argument, it would fail with Error: MetricReader can not be bound to a MeterProvider again.

On the other hand, similarly to you code, @opentelemetry/exporter-metrics-otlp-http shows usage where the meter provider is used directly and it should "just work".

And yet, cube-creator's metrics do show up in prometheus. Any ideas?

Copy link
Member

@ludovicm67 ludovicm67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some logic for the metrics should be moved to the SDK part.
This will register them globally.

cli/lib/otel/metrics.ts Outdated Show resolved Hide resolved
cli/lib/otel/metrics.ts Outdated Show resolved Hide resolved
cli/lib/otel/index.ts Show resolved Hide resolved
@tpluscode tpluscode marked this pull request as ready for review March 2, 2023 09:40
@tpluscode tpluscode merged commit 319e602 into master Mar 2, 2023
@tpluscode tpluscode deleted the otel-upgrade branch March 2, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants