-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update opentelemetry #1377
Conversation
🦋 Changeset detectedLatest commit: 38a0114 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1377 +/- ##
==========================================
- Coverage 80.84% 80.77% -0.08%
==========================================
Files 197 196 -1
Lines 13383 13399 +16
Branches 736 736
==========================================
+ Hits 10820 10823 +3
- Misses 2555 2568 +13
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Ludovic Muller <[email protected]>
Co-authored-by: Ludovic Muller <[email protected]>
Co-authored-by: Ludovic Muller <[email protected]>
6c7d79d
to
c361eae
Compare
Jaeger traces are back when I applied your changes but no metrics are being collected still I'm pretty sure that I am configuring something wrong. Compared to the example you showed me @ludovicm67, I am using On the other hand, similarly to you code, @opentelemetry/exporter-metrics-otlp-http shows usage where the meter provider is used directly and it should "just work". And yet, cube-creator's metrics do show up in prometheus. Any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some logic for the metrics should be moved to the SDK part.
This will register them globally.
No description provided.