zcash_keys: Add a test for parsing a problematic mainnet address.

zcash · Oct 14, 2024 · 2df32e0 · 2df32e0
1 parent dd51c2a
commit 2df32e0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/zcash_keys/Cargo.toml b/zcash_keys/Cargo.toml
@@ -67,6 +67,7 @@ byteorder = { workspace = true, optional = true }
 blake2b_simd = { workspace = true }
 
 [dev-dependencies]
+assert_matches.workspace = true
 hex.workspace = true
 jubjub.workspace = true
 proptest.workspace = true

diff --git a/zcash_keys/src/encoding.rs b/zcash_keys/src/encoding.rs
@@ -517,13 +517,16 @@ pub fn decode_transparent_address(
 #[cfg(test)]
 #[cfg(feature = "sapling")]
 mod tests_sapling {
+    use assert_matches::assert_matches;
+    use zcash_protocol::consensus::Network;
+
     use super::{
         decode_extended_full_viewing_key, decode_extended_spending_key, decode_payment_address,
         encode_extended_full_viewing_key, encode_extended_spending_key, encode_payment_address,
-        Bech32DecodeError,
+        AddressCodec, Bech32DecodeError,
     };
     use sapling::{zip32::ExtendedSpendingKey, PaymentAddress};
-    use zcash_primitives::constants;
+    use zcash_primitives::{constants, legacy::TransparentAddress};
 
     #[test]
     fn extended_spending_key() {
@@ -689,4 +692,14 @@ mod tests_sapling {
             Err(Bech32DecodeError::ReadError)
         );
     }
+
+    #[test]
+    fn linear_pro_278() {
+        let encoded = "t1gDxhpMTfKJCyTgUHppnEkUonrcqMVL8J8";
+
+        assert_matches!(
+            TransparentAddress::decode(&Network::MainNetwork, encoded),
+            Ok(_)
+        );
+    }
 }