implement 'read' for BlockDb so it can call 'scan_cached_blocks'

zcash · Oct 28, 2024 · d8df635 · d8df635
1 parent 4c83f30
commit d8df635
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/zcash_client_sqlite/CHANGELOG.md b/zcash_client_sqlite/CHANGELOG.md
@@ -22,6 +22,7 @@ and this library adheres to Rust's notion of
   - wrapped `Connection` field in an arc mutex to implement `Sync` trait
   - updated `with_blocks` to match changes to `BlockSource` trait
   - added unimplemented `BlockCache` trait methods
+  - implemented `BlockCache::read` trait method
 - `zcash_client_sqlite::FsBlockDb`:
   - wrapped `conn` field in an arc mutex to implement `Sync` trait
   - wrapped `blocks_dir` field in an arc to implement `Sync` trait

diff --git a/zcash_client_sqlite/src/lib.rs b/zcash_client_sqlite/src/lib.rs
@@ -1663,7 +1663,17 @@ impl BlockCache for BlockDb {
         &self,
         range: &ScanRange,
     ) -> Result<Vec<CompactBlock>, data_api::chain::error::Error<WalletErrT, Self::Error>> {
-        todo!()
+        let mut compact_blocks = vec![];
+        self.with_blocks(
+            Some(range.block_range().start),
+            Some(range.len()),
+            |block| {
+                compact_blocks.push(block);
+                Ok(())
+            },
+        )
+        .await?;
+        Ok(compact_blocks)
     }
 
     async fn insert<WalletErrT>(