Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

equihash: Fix some Rust API issues #1088

Merged
merged 34 commits into from
Jan 26, 2024
Merged

equihash: Fix some Rust API issues #1088

merged 34 commits into from
Jan 26, 2024

Commits on Jan 11, 2024

  1. Verify compressed solutions in tests

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    8b72e5c View commit details
    Browse the repository at this point in the history

  2. Satisfy some lints

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5a379ae View commit details
    Browse the repository at this point in the history

  3. Only recompile C code if it has changed

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    37bd242 View commit details
    Browse the repository at this point in the history

  4. Use a 2-byte nonce range in the test

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a73577c View commit details
    Browse the repository at this point in the history

  5. Print solution candidates for debugging

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    f379976 View commit details
    Browse the repository at this point in the history

  6. Add review comments

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    ca77763 View commit details
    Browse the repository at this point in the history

  7. Only do 30 runs for time trials

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    18062e4 View commit details
    Browse the repository at this point in the history

  8. Move allocation out of the loop

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    04251a0 View commit details
    Browse the repository at this point in the history

  9. Add safety comments

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    2ae77d5 View commit details
    Browse the repository at this point in the history

  10. Skip already tried nonces

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    c5f0e2e View commit details
    Browse the repository at this point in the history

  11. More safety comments

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5b06acf View commit details
    Browse the repository at this point in the history

  12. Fix a memory handling issue in the solution array

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e0ff3ec View commit details
    Browse the repository at this point in the history

  13. Avoid a panic by ignoring overflow when shifting

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    41f4035 View commit details
    Browse the repository at this point in the history

  14. Restore the duplicate indexes check

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d16a40f View commit details
    Browse the repository at this point in the history

  15. Disable debug-printing in production code

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d8745c9 View commit details
    Browse the repository at this point in the history

  16. Just print duplicate indexes

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    4da29c8 View commit details
    Browse the repository at this point in the history

  17. Fix a C++ to C conversion bug with references

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    7e7018e View commit details
    Browse the repository at this point in the history

  18. Fix unbraced conditional bugs in unused code

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5dfd2ad View commit details
    Browse the repository at this point in the history

  19. Add some redundant cleanup code, but comment it out

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    3053149 View commit details
    Browse the repository at this point in the history

  20. Test 4 bytes of changing nonce

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6d284e2 View commit details
    Browse the repository at this point in the history

  21. Comment out some verbose debug code

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b9c5095 View commit details
    Browse the repository at this point in the history

  22. Fix a type cast error in compress_array() C++ to Rust conversion

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    3f60a59 View commit details
    Browse the repository at this point in the history

  23. Clean up test code

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    0be63ff View commit details
    Browse the repository at this point in the history

  24. Add an optional solver feature

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    3043684 View commit details
    Browse the repository at this point in the history

  25. Set C pointers to NULL after freeing them to avoid double-frees

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    daaaa6a View commit details
    Browse the repository at this point in the history

  26. Fix a memory leak in equi_setstate()

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5e244ec View commit details
    Browse the repository at this point in the history

  27. Check returned solutions are unique

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d2c4765 View commit details
    Browse the repository at this point in the history

  28. Forward-declare a C function

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    617e3b2 View commit details
    Browse the repository at this point in the history

  29. Add a portable endian.h for htole32() on macOS and Windows

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e831375 View commit details
    Browse the repository at this point in the history

  30. Remove unused thread support to enable Windows compilation

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    cc2f2d7 View commit details
    Browse the repository at this point in the history

  31. Don't import a header that's missing in Windows CI

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    742ca1b View commit details
    Browse the repository at this point in the history

  32. MSVC demands more constant expressions

    @teor2345
    teor2345 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    97a1e0a View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Clear slots when setting the hash state

    @teor2345
    teor2345 authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    e879477 View commit details
    Browse the repository at this point in the history

  2. Keep the C worker up to date with Rust bug fixes

    @teor2345
    teor2345 authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    aff6fac View commit details
    Browse the repository at this point in the history