Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transparent-source-only (TEX) addresses #1257

Merged
merged 56 commits into from
Jul 17, 2024

Remove `ChangeValue::new`. Also document `ChangeValue::is_ephemeral` as

d32b7db
Select commit
Loading
Failed to load commit list.
Merged

Add support for transparent-source-only (TEX) addresses #1257

Remove `ChangeValue::new`. Also document `ChangeValue::is_ephemeral` as
d32b7db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 29, 2024 in 1s

63.90% (+0.69%) compared to 5bd911f

View this Pull Request on Codecov

63.90% (+0.69%) compared to 5bd911f

Details

Codecov Report

Attention: Patch coverage is 75.50059% with 208 lines in your changes missing coverage. Please review.

Project coverage is 63.90%. Comparing base (5bd911f) to head (d32b7db).

❗ Current head d32b7db differs from pull request most recent head bc38f2a

Please upload reports for the commit bc38f2a to get more accurate results.

Files Patch % Lines
zcash_client_backend/src/data_api/wallet.rs 71.65% 53 Missing ⚠️
..._client_sqlite/src/wallet/transparent/ephemeral.rs 67.20% 41 Missing ⚠️
zcash_client_backend/src/data_api.rs 5.55% 17 Missing ⚠️
zcash_client_backend/src/wallet.rs 34.61% 17 Missing ⚠️
zcash_client_sqlite/src/lib.rs 72.22% 15 Missing ⚠️
zcash_client_backend/src/proto.rs 18.75% 13 Missing ⚠️
zcash_client_backend/src/fees/common.rs 91.30% 12 Missing ⚠️
zcash_client_sqlite/src/wallet/transparent.rs 86.58% 11 Missing ⚠️
zcash_client_backend/src/proposal.rs 0.00% 8 Missing ⚠️
...ent_backend/src/data_api/wallet/input_selection.rs 94.69% 6 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
+ Coverage   63.20%   63.90%   +0.69%     
==========================================
  Files         128      130       +2     
  Lines       14869    15391     +522     
==========================================
+ Hits         9398     9835     +437     
- Misses       5471     5556      +85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov