Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_backend: Pure refactoring for note selection ergonomics. #1271

Merged

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Mar 14, 2024

This is a pure refactoring that should result in no functional changes.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 69.66292% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 63.50%. Comparing base (2e0a300) to head (0bae47b).

Files Patch % Lines
zcash_client_backend/src/data_api.rs 74.28% 9 Missing ⚠️
zcash_client_sqlite/src/lib.rs 50.00% 9 Missing ⚠️
...ent_backend/src/data_api/wallet/input_selection.rs 71.42% 6 Missing ⚠️
zcash_client_backend/src/wallet.rs 81.81% 2 Missing ⚠️
zcash_client_sqlite/src/wallet/orchard.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
+ Coverage   63.48%   63.50%   +0.02%     
==========================================
  Files         121      121              
  Lines       13678    13711      +33     
==========================================
+ Hits         8683     8707      +24     
- Misses       4995     5004       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit be312f8 into zcash:main Mar 14, 2024
22 of 25 checks passed
@nuttycom nuttycom deleted the sqlite_wallet/cross_pool_selection_refactor branch March 14, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants