Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_backend: Rename AccountKind to AccountSource #1272

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

nuttycom
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 63.42%. Comparing base (1775f65) to head (ab3e790).

Files Patch % Lines
zcash_client_backend/src/data_api.rs 0.00% 4 Missing ⚠️
zcash_client_sqlite/src/wallet.rs 60.00% 4 Missing ⚠️
zcash_client_sqlite/src/lib.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1272   +/-   ##
=======================================
  Coverage   63.42%   63.42%           
=======================================
  Files         121      121           
  Lines       13705    13705           
=======================================
  Hits         8693     8693           
  Misses       5012     5012           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ab3e790

zcash_client_sqlite/src/wallet.rs Show resolved Hide resolved
@str4d str4d added this to the Librustzcash Zashi 1.0 milestone Mar 18, 2024
@str4d str4d merged commit da64e8a into zcash:main Mar 18, 2024
21 of 25 checks passed
@nuttycom nuttycom deleted the account_source branch March 23, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants