zcash_client_sqlite: Add unstable conversions between AccountId and u32.
#1557
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1557 +/- ##
==========================================
- Coverage 61.63% 61.62% -0.02%
==========================================
Files 148 148
Lines 18821 18825 +4
==========================================
Hits 11601 11601
- Misses 7220 7224 +4 ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
add_accountid_conversions
branch
3 times, most recently
from
ae012b3
to
58edf9c
Compare
… `u32` This is necessary for third parties using the `zcash_client_sqlite` crate directly to be able to refer to individual account IDs without having to always use FVKs to look them up.
nuttycom
force-pushed
the
add_accountid_conversions
branch
from
58edf9c
to
cb349f8
Compare
daira
reviewed
Oct 6, 2024
| /// Constructs an `AccountId` from a bare `u32` value. The resulting identifier is not | ||
| /// guaranteed to correspond to any account stored in the database. | ||
| #[cfg(feature = "unstable")] | ||
| pub fn from_u32(value: u32) -> Self { |
There was a problem hiding this comment.
Should this be unsafe?
Suggested change
| pub fn from_u32(value: u32) -> Self { | |
| pub unsafe fn from_u32(value: u32) -> Self { |
There was a problem hiding this comment.
This isn't unsafe, by any meaning of the term?
There was a problem hiding this comment.
It's up to the caller to maintain the intended invariant that AccountIds are only constructed for accounts stored in the database, which isn't checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for third parties using the
zcash_client_sqlitecrate directly to be able to refer to individual account IDs without having to always use FVKs to look them up.