Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Ensure that all shielded change outputs are correctly flagged. #1585

Merged
merged 5 commits into from
Oct 25, 2024
Merged

zcash_client_sqlite: Ensure that all shielded change outputs are correctly flagged. #1585

merged 5 commits into from
Oct 25, 2024

Commits on Oct 24, 2024

  1. zcash_client_sqlite: Add a test demonstrating the bug described in zc… 

    …ash#1571

The update to a shielding transaction causes the information that the
output is considered change to be lost. This happens because the
scanning process does not have access to any information about the
inputs to the transaction, and so it does not recognize the output as
change.
    @nuttycom
    nuttycom committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bcd8617 View commit details
    Browse the repository at this point in the history

  2. zcash_client_sqlite: Make it possible to initialize tests to a specif… 

    …ic migration state.
    @nuttycom
    nuttycom committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    05ee294 View commit details
    Browse the repository at this point in the history

  3. zcash_client_sqlite: Add a migration to fix broken is_change flagging

    @nuttycom
    nuttycom committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6fb4f5c View commit details
    Browse the repository at this point in the history

  4. zcash_client_sqlite: Once a note is determined to be change, don't re… 

    …scind that determination.

This is a minimal and correct but incomplete fix for
zcash#1571. Additional work to distinguish change outputs
is necessary to update existing wallets that have made an incorrect
change determination in the past.
    @nuttycom
    nuttycom committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    76ca8fc View commit details
    Browse the repository at this point in the history

  5. zcash_client_sqlite: Ensure that previously-received change is correc… 

    …tly flagged when recording sent outputs.

Fixes zcash#1571
    @nuttycom
    nuttycom committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d753090 View commit details
    Browse the repository at this point in the history