Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_extensions: Fix build errors following value changes to zcash_protocol #1683

Merged
1 commit merged into from
Jan 29, 2025

Conversation

nuttycom
Copy link
Contributor

This fixes a few errors that have been introduced over time since zcash_extensions is not regularly built, and migrates zcash_extensions to eliminate the use of deprecated zcash_primitives APIs.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.90%. Comparing base (1b09741) to head (b823aa3).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
zcash_primitives/src/transaction/builder.rs 0.00% 2 Missing ⚠️
...imitives/src/transaction/components/tze/builder.rs 0.00% 2 Missing ⚠️
zcash_primitives/src/transaction/components/tze.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1683   +/-   ##
=======================================
  Coverage   51.89%   51.90%           
=======================================
  Files         180      180           
  Lines       21169    21167    -2     
=======================================
  Hits        10986    10986           
+ Misses      10183    10181    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom nuttycom force-pushed the fix_tze_build branch 2 times, most recently from e14b9aa to b236665 Compare January 29, 2025 00:33
…protocol`

This fixes a few errors that have been introduced over time since
`zcash_extensions` is not regularly built, and migrates
`zcash_extensions` to eliminate the use of deprecated `zcash_primitives`
APIs.
@nuttycom nuttycom closed this pull request by merging all changes into zcash:main in 3cc8a13 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant