Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_primitives: Add no_std support #1688

Merged
merged 6 commits into from
Jan 29, 2025

Apply suggestions from code review

d352b93
Select commit
Loading
Failed to load commit list.
Merged

zcash_primitives: Add no_std support #1688

Apply suggestions from code review
d352b93
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2025 in 0s

52.00% (+0.10%) compared to 1b09741

View this Pull Request on Codecov

52.00% (+0.10%) compared to 1b09741

Details

Codecov Report

Attention: Patch coverage is 72.95082% with 33 lines in your changes missing coverage. Please review.

Project coverage is 52.00%. Comparing base (1b09741) to head (d352b93).

Files with missing lines Patch % Lines
zcash_primitives/src/merkle_tree.rs 33.33% 16 Missing ⚠️
...h_primitives/src/transaction/components/orchard.rs 70.00% 3 Missing ⚠️
zcash_primitives/src/transaction/components/tze.rs 0.00% 3 Missing ⚠️
zcash_primitives/src/encoding.rs 93.54% 2 Missing ⚠️
zcash_primitives/src/transaction/builder.rs 50.00% 2 Missing ⚠️
...sh_primitives/src/transaction/components/sprout.rs 0.00% 2 Missing ⚠️
...imitives/src/transaction/components/tze/builder.rs 0.00% 2 Missing ⚠️
...h_primitives/src/transaction/components/sapling.rs 66.66% 1 Missing ⚠️
zcash_primitives/src/transaction/fees/zip317.rs 0.00% 1 Missing ⚠️
zcash_primitives/src/transaction/mod.rs 93.75% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   51.89%   52.00%   +0.10%     
==========================================
  Files         180      181       +1     
  Lines       21169    21192      +23     
==========================================
+ Hits        10986    11021      +35     
+ Misses      10183    10171      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov