-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bedrock Cloud Model provider #21092
base: main
Are you sure you want to change the base?
Add Bedrock Cloud Model provider #21092
Conversation
This still needs to be updated to the new method of managing models, going to spend the next couple of weeks migrating to it. |
Zed maintainers, would appreciate some guidance on how the ZedPro things are setup and if it makes sense to pass the Bedrock models into it. On a cursory reading of the feature, i don't believe it does -- however, i am open to working with the bedrock service team to make it a reality. |
I don't think you need to pass through the bedrock models through the collab service, as Zed would need to run their own bedrock setup. I'd just do the API key / AWS credentials route. |
Unfortunately, our CLA bot is broken, so I have to substitute for it for a while:
|
Will get it done post a legal review of the docs (just want to make sure AWS doesn't have an issue with it) |
@cla-bot check |
Some conversations with the AWS SDK team later, the best recommendation from them is to SigV4 the requests manually and then just interact with the raw API, will pivot to that in the coming weeks. |
cd86db4
to
61c31d8
Compare
We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
The cla-bot has been summoned, and re-checked this pull request! |
We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@SomeoneToIgnore Please call off the cla-bot 😂 |
I'm afraid I was only able to act like one when it was down. |
We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
…rock errors, while also letting us include it
…tion and its' failing to cascade
The tests are failing with some GlobalTokio unwrap that is outside my codebase, can someone look at the full breakdown and understand what's going on? Or i can setup a graceful failure in Bedrock in case of a failed tokio spawn. |
If we can get all tests to pass, i would be fine taking on tool use as a followup action item rather than blocking this PR |
Yeah @mikayla-maki might need your insight on this, looks like GPUI tokio is failing to get a tokio handle on restart? which is causing the bedrock provider to crash in the tests. |
…he test suite app context
Closes #16544
Release Notes: