Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bedrock Cloud Model provider #21092

Open
wants to merge 69 commits into
base: main
Choose a base branch
from

Conversation

5herlocked
Copy link

Closes #16544

Release Notes:

  • Added support for Bedrock as an FM provider
  • Added rudimentary support for AWS credential management to Zed

@5herlocked
Copy link
Author

This still needs to be updated to the new method of managing models, going to spend the next couple of weeks migrating to it.

@5herlocked
Copy link
Author

5herlocked commented Nov 23, 2024

Zed maintainers, would appreciate some guidance on how the ZedPro things are setup and if it makes sense to pass the Bedrock models into it.

On a cursory reading of the feature, i don't believe it does -- however, i am open to working with the bedrock service team to make it a reality.

@maxdeviant maxdeviant changed the title feature: Bedrock Cloud Model provider Add Bedrock Cloud Model provider Nov 23, 2024
@rgbkrk
Copy link
Member

rgbkrk commented Nov 23, 2024

I don't think you need to pass through the bedrock models through the collab service, as Zed would need to run their own bedrock setup. I'd just do the API key / AWS credentials route.

@SomeoneToIgnore
Copy link
Contributor

Unfortunately, our CLA bot is broken, so I have to substitute for it for a while:

We require contributors to sign our Contributor License Agreement, and we don't have @5herlocked on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@5herlocked
Copy link
Author

Will get it done post a legal review of the docs (just want to make sure AWS doesn't have an issue with it)

@5herlocked
Copy link
Author

@cla-bot check

@notpeter notpeter added the cla-signed The user has signed the Contributor License Agreement label Nov 25, 2024
crates/collab/src/llm.rs Outdated Show resolved Hide resolved
@5herlocked
Copy link
Author

Some conversations with the AWS SDK team later, the best recommendation from them is to SigV4 the requests manually and then just interact with the raw API, will pivot to that in the coming weeks.

@5herlocked 5herlocked force-pushed the feature/bedrock-provider branch from cd86db4 to 61c31d8 Compare January 17, 2025 17:30
Copy link

cla-bot bot commented Jan 17, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot cla-bot bot removed the cla-signed The user has signed the Contributor License Agreement label Jan 17, 2025
@5herlocked
Copy link
Author

@cla-bot check

Copy link

cla-bot bot commented Jan 17, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

Copy link

cla-bot bot commented Jan 17, 2025

The cla-bot has been summoned, and re-checked this pull request!

Copy link

cla-bot bot commented Jan 17, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

Copy link

cla-bot bot commented Jan 19, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@5herlocked
Copy link
Author

@SomeoneToIgnore Please call off the cla-bot 😂

@SomeoneToIgnore
Copy link
Contributor

I'm afraid I was only able to act like one when it was down.
I suspect you need to alter f798bf4 commit's author or ask that bot to sign the CLA 🙂

Copy link

cla-bot bot commented Jan 20, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @deepsource-io[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@5herlocked
Copy link
Author

The tests are failing with some GlobalTokio unwrap that is outside my codebase, can someone look at the full breakdown and understand what's going on? Or i can setup a graceful failure in Bedrock in case of a failed tokio spawn.

@5herlocked
Copy link
Author

If we can get all tests to pass, i would be fine taking on tool use as a followup action item rather than blocking this PR

@5herlocked
Copy link
Author

Yeah @mikayla-maki might need your insight on this, looks like GPUI tokio is failing to get a tokio handle on restart? which is causing the bedrock provider to crash in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS Bedrock as an Assistant provider
6 participants