Add debounced submission on input in project search #24086
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @Tebro on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
| @@ -168,6 +169,8 @@ pub struct ProjectSearchView { | |||
| replace_enabled: bool, | |||
| included_opened_only: bool, | |||
| _subscriptions: Vec<Subscription>, | |||
| search_debounce: Option<Task<()>>, | |||
| prevent_focus_results: bool, | |||
There was a problem hiding this comment.
Is there a better way to handle this state?
There was a problem hiding this comment.
Been trying to solve the issue of keeping the prevent_focus_results as struct field. I don't really like having it there but can't quite figure out how to make it proper. Any suggestions would be welcome.
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
maxdeviant
changed the title
| @@ -335,6 +335,11 @@ | |||
| "include_ignored": false, | |||
| "regex": false | |||
| }, | |||
| // These settings define whether the project search should search as you type, or only on enter. | |||
| "project_search": { | |||
| "automatic_submission": true, | |||
There was a problem hiding this comment.
Nit: maybe you don't need to have a separate automatic_submission setting, as you could determine it based on whether the automatic_submission_delay is non-null.
|
Thanks for working on this! I realized that we probably need to do some UI design work before being able to merge this feature. Added some thoughts in a comment on the issue. If the |
Closes #9318
Release Notes: