Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: Escape to normal mode when visual surround operation pending #24484

Merged

Conversation

roycrippen4
Copy link
Contributor

@roycrippen4 roycrippen4 commented Feb 7, 2025

Closes #24382

Release Notes:

  • vim: Ensure escape in surrounds mode returns to normal mode

Copy link

cla-bot bot commented Feb 7, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: roy.crippen4.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@roycrippen4
Copy link
Contributor Author

I have no idea how to fix this workflow issue. The bot failed to parse my work email from my gitconfig.

@ConradIrwin
Copy link
Member

@roycrippen4 If you sign the CLA at https://zed.dev/cla, I can manually verify you've done so

@roycrippen4
Copy link
Contributor Author

@ConradIrwin I signed it

Copy link

cla-bot bot commented Feb 8, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: roy.crippen4.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@ConradIrwin
Copy link
Member

Thanks! can confirm the CLA is signed.

Now about that test, it seems like we don't want to do this if we're currently waiting for a register after ctrl-r in insert mode (and from testing vim, nor after " in visual mode).

I've pushed a change that scopes this fix just to add-surrounds mode, but please let me know if we need it for more.

@ConradIrwin ConradIrwin merged commit d9183c7 into zed-industries:main Feb 8, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor Stays in Visual Mode After Escape in Visual Surround Operation
2 participants