Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim: Update yank, delete to use target_visual_mode for objects #24513

Closed
wants to merge 2 commits into from
Closed

vim: Update yank, delete to use target_visual_mode for objects #24513

wants to merge 2 commits into from

Conversation

5brian
Copy link
Contributor

@5brian 5brian commented Feb 8, 2025

Closes #24264

Changes:

I think the proximate cause here is that we target visual line mode for the selection. We should update yank to look for the target visual mode of the object to fix this.
#24264 (comment)

Release Notes:

  • N/A or Added/Fixed/Improved ...

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 8, 2025
@zed-industries-bot
Copy link

zed-industries-bot commented Feb 8, 2025 •
edited
Loading

Messages
📖

This PR includes links to the following GitHub Issues: #24264
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against e823448

@5brian 5brian changed the title vim: Update yank to use target_visual_mode for objects vim: Update yank, delete to use target_visual_mode for objects Feb 8, 2025
@5brian
Copy link
Contributor Author

5brian commented Feb 9, 2025

i did this wrong

@5brian 5brian closed this Feb 9, 2025
@5brian 5brian deleted the vim-yank-use-visual-mode branch February 9, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vim: yaf in typescript is not the same as vafy for arrow functions
2 participants
@5brian @zed-industries-bot